Explicitly exit retired renderers. #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
changed the title
Before, this was waiting for GC to clean up unused renderers, which might not happen if renderers were created and destroyed without a major GC event. If GC didn't occur, the webgl context wouldn't be released. This explicitly exits the renderers (and explicitly loses the webgl context) as soon as the renderer is no longer in use (due to autosharing).
manthey
force-pushed
the
explicitly-lose-context
branch
from
0d5174a to
b433cfb
Compare
Previously, this was done on z-index changes. Since layers can be rendered in shared canvases, this is needed on layer removal or addition since that can effect the overall computed tile layer offsets.
The default (`true` setting) will only autoshare if it is likely to not result in a visual difference (layer opacity 0 or 1, tile layers below non-tile layers). The `"more"` setting will perform as before this PR -- autosharing if the opacities are identical and irrespective of the mixing of tile and non-tile layers. `false`, as before, won't autoshare. This also adds a map level setting of `autoshareRenderer` which sets the defaults for newly created levels.
matthewma7
approved these changes
Jul 10, 2019
Add a third state for autoshareRenderer.
Clear quads on layer addition and removal.
manthey
force-pushed
the
explicitly-lose-context
branch
from
c061d6a to
72fd125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this was waiting for GC to clean up unused renderers, which might not happen if renderers were created and destroyed without a major GC event. If GC didn't occur, the webgl context wouldn't be released. This explicitly exits the renderers (and explicitly loses the webgl context) as soon as the renderer is no longer in use (due to autosharing).