Merge pull request #1039 from OpenGeoscience/remove-needless-calls

Remove some needless calls.
OpenGeoscience · Oct 9, 2019 · cff40dc · cff40dc
2 parents 722e55c + d8cfcf1
commit cff40dc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Change Log
 
+## Unreleased
+
+### Bug Fixes
+- Removed extra calls to sceneObject constructors (#1039)
+
 ## Version 0.19.7
 
 ### Features

diff --git a/src/canvas/object.js b/src/canvas/object.js
@@ -1,6 +1,3 @@
-var inherit = require('../inherit');
-var sceneObject = require('../sceneObject');
-
 /**
  * Canvas specific subclass of object which rerenders when the object is drawn.
  * @class
@@ -19,7 +16,6 @@ var canvas_object = function (arg) {
   if (!(this instanceof object)) {
     return new canvas_object(arg);
   }
-  sceneObject.call(this);
 
   var m_this = this,
       s_draw = this.draw,
@@ -81,5 +77,4 @@ var canvas_object = function (arg) {
   return this;
 };
 
-inherit(canvas_object, sceneObject);
 module.exports = canvas_object;
diff --git a/src/svg/object.js b/src/svg/object.js
@@ -1,6 +1,3 @@
-var inherit = require('../inherit');
-var sceneObject = require('../sceneObject');
-
 /**
  * SVG specific subclass of object which adds an id property for d3 selections
  * on groups of objects by class id.
@@ -22,7 +19,6 @@ var svg_object = function (arg) {
   if (!(this instanceof object)) {
     return new svg_object(arg);
   }
-  sceneObject.call(this);
 
   var m_id = 'svg-' + uniqueID(),
       s_exit = this._exit,
@@ -66,5 +62,4 @@ var svg_object = function (arg) {
   return this;
 };
 
-inherit(svg_object, sceneObject);
 module.exports = svg_object;