Skip to content

Commit

Permalink
Fix testing with Chrome 65.
Browse files Browse the repository at this point in the history
Chrome 65 was released 2018-3-6.  With it, some vertices appear odd in
GL rendered lines, but only on the headless GL or xvfb tests.  This
doesn't affect how the tests are rendered in Chrome 65 on a desktop, so
it is likely some sort of Chrome-65-with-mesa issue.  This is not a mesa
issue, since it was not updated.

Since this is just a testing artifact, rather than change the baselines,
relax the strictness of the image comparison.  Note that if travis
allowed pinning to a specific version of Chrome, I'd recommend pinning
to version 64 until Chrome fixes their issue.
  • Loading branch information
manthey committed Mar 7, 2018
1 parent 675fa21 commit 825206e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
4 changes: 3 additions & 1 deletion tests/gl-cases/glLines.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion tests/gl-cases/glPolygons.js
Original file line number Diff line number Diff line change
Expand Up @@ -2446,7 +2446,9 @@ describe('glPolygons', function () {
layer: layer
}).read(JSON.stringify(data), function () {
myMap.draw();
imageTest.imageTest('glMultiPolygons', null, 0.0015, done, myMap.onIdle, 0, 2);
// maximum error is 0.0030 because of a change in Chrome 65. When new
// versions are released, see if this can be moved back to 0.0015
imageTest.imageTest('glMultiPolygons', null, 0.0030, done, myMap.onIdle, 0, 2);
});
});

Expand Down
4 changes: 3 additions & 1 deletion tests/headed-cases/lines.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ describe('lines example', function () {
it('more lines', function (done) {
base$ = $('iframe#map')[0].contentWindow.jQuery;
base$('#lines').val(100000).trigger('change');
imageTest.imageTest('exampleLines100k', '#map', 0.0015, done, null, 0, 2, '#map.ready[segments="100000"]');
// maximum error is 0.0030 because of a change in Chrome 65. When new
// versions are released, see if this can be moved back to 0.0015
imageTest.imageTest('exampleLines100k', '#map', 0.0030, done, null, 0, 2, '#map.ready[segments="100000"]');
}, 10000);
it('thin preset', function (done) {
base$('button.preset').eq(1).trigger('click');
Expand Down

0 comments on commit 825206e

Please sign in to comment.