Merge pull request #609 from OpenGeoscience/geojson-empty-geometries

Ignore geojson features with empty coordinates
OpenGeoscience · Aug 26, 2016 · 0a6efce · 0a6efce
2 parents 60335a1 + 12006b9
commit 0a6efce
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/src/jsonReader.js b/src/jsonReader.js
@@ -133,6 +133,13 @@ var jsonReader = function (arg) {
     features.forEach(function (feature) {
       Array.prototype.push.apply(normalized, m_this._feature(feature));
     });
+
+    // remove features with empty geometries
+    normalized = normalized.filter(function (feature) {
+      return feature.geometry &&
+        feature.geometry.coordinates &&
+        feature.geometry.coordinates.length;
+    });
     return normalized;
   };
 

diff --git a/tests/cases/geojsonReader.js b/tests/cases/geojsonReader.js
@@ -213,6 +213,31 @@ describe('geojsonReader', function () {
           coordinates: [1, 1]
         }
       }]);
+
+      it('empty geometry', function () {
+        expect(reader._featureArray({
+          type: 'FeatureCollection',
+          features: [{
+            type: 'Feature',
+            geometry: {
+              type: 'Point',
+              coordinates: []
+            }
+          }, {
+            type: 'Feature',
+            geometry: {
+              type: 'LineString',
+              coordinates: []
+            }
+          }, {
+            type: 'Feature',
+            geometry: {
+              type: 'Polygon',
+              coordinates: []
+            }
+          }]
+        })).toEqual([]);
+      });
     });
 
     describe('Errors', function () {