-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support collections in provisioner #2852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…ner-support-collections
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2852 +/- ##
=======================================
Coverage 91.41% 91.42%
=======================================
Files 343 343
Lines 12355 12367 +12
=======================================
+ Hits 11294 11306 +12
Misses 1061 1061 ☔ View full report in Codecov by Sentry. |
stuartc
approved these changes
Jan 30, 2025
elias-ba
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
collections
in the provisionerCloses #2830
Validation steps
In order to test this, you need to have the
cli
installed.from this branch: OpenFn/kit#860Make sure you have the latest version,You can install it using the command:
pnpm install:global
and access it usingopenfnx
command.1.10.3
, which supports collections.npm install -g @openfn/cli
From the cli, this is supported via the
collections
key:Additional notes for the reviewer
This PR depends on OpenFn/kit#860 . The failing test is an end to end test. In order to fix it, we'll need to release a new version of thecli
with those changesDevs will need to update the runtime installation to get this test running locally:
mix lightning.install_runtime
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)