Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support collections in provisioner #2852

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

midigofrank
Copy link
Collaborator

@midigofrank midigofrank commented Jan 23, 2025

Description

This PR adds support for collections in the provisioner

Closes #2830

Validation steps

In order to test this, you need to have the cli installed. from this branch: OpenFn/kit#860
You can install it using the command: pnpm install:global and access it using openfnx command.
Make sure you have the latest version, 1.10.3, which supports collections. npm install -g @openfn/cli

From the cli, this is supported via the collections key:

name: openhie-project
description: null
collections:
  dummy:
    name: dummy

Additional notes for the reviewer

This PR depends on OpenFn/kit#860 . The failing test is an end to end test. In order to fix it, we'll need to release a new version of the cli with those changes
Devs will need to update the runtime installation to get this test running locally: mix lightning.install_runtime

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@midigofrank midigofrank self-assigned this Jan 23, 2025
@midigofrank midigofrank marked this pull request as ready for review January 28, 2025 06:37
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (e7291f3) to head (2941e65).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2852   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files         343      343           
  Lines       12355    12367   +12     
=======================================
+ Hits        11294    11306   +12     
  Misses       1061     1061           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@midigofrank midigofrank merged commit 21d36d1 into main Feb 4, 2025
8 checks passed
@midigofrank midigofrank deleted the 2830-provisioner-support-collections branch February 4, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extend provisioning to support collections at a project level
3 participants