Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2617 slow editor add index #2849

Merged
merged 4 commits into from
Jan 27, 2025
Merged

2617 slow editor add index #2849

merged 4 commits into from
Jan 27, 2025

Conversation

rorymckinley
Copy link
Collaborator

Description

This adds 2 indexes for foreign keys. Given the urgency expressed around having a solution to the editor load times, I am pushing the low-hanging fruit out early rather than waiting for a complete solution.

Future discoveries/changes may make these indexes redundant.

This is why this PR does not close the issue.

#2617

Validation steps

Nothing really - other than the indexes, there are no functional changes in this PR.

Additional notes for the reviewer

Apparently, Pizza Hut started with thin base pizza because the founders only knew how to make the dough needed for French bread - which results in a thin base pizza. Before then pizzas had thicker bases.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (f0f6111) to head (114f3d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2849      +/-   ##
==========================================
+ Coverage   91.39%   91.41%   +0.02%     
==========================================
  Files         340      340              
  Lines       12267    12267              
==========================================
+ Hits        11211    11214       +3     
+ Misses       1056     1053       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rorymckinley rorymckinley marked this pull request as ready for review January 22, 2025 11:35
- Attempting to resolve slow editor loading issues
@rorymckinley rorymckinley force-pushed the 2617-slow-editor-add-index branch from 3f378bd to 114f3d1 Compare January 25, 2025 07:00
@midigofrank midigofrank merged commit acc7f12 into main Jan 27, 2025
5 of 6 checks passed
@midigofrank midigofrank deleted the 2617-slow-editor-add-index branch January 27, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants