-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI small fixes #2266
base: main
Are you sure you want to change the base?
UI small fixes #2266
Conversation
3236745
to
2be8d67
Compare
<button | ||
type="button" | ||
class="relative w-full cursor-default rounded-md bg-white py-1.5 pl-3 | ||
<%= if length(assigns[:projects]) == 0 do %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When accessing assigns in Heex templates, please use @projects
- that way the renderer can optimise for diffs/prevent rerenderers.
The example below, assigns[:selected_project]
is an exception to the rule since in that specific case we don't know if there is an assign with that key.
But for any other case, we always use the @name
style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys, sorry for the delay, I ended up going on a trip as I am in my vacation.
Validation Steps
reference for the original bug https://www.loom.com/share/58feb3af170a42fdbe70a127843bb7cb
...
for thephx-disable-with
text.Notes for the reviewer
At the
lib/lightning_web/live/components/menu.ex
, github fails to diff in a good way. You can notice that the previous code is the same as in theelse
block, this should simplify the review.Related issue
Fixes #2212
Review checklist
:owner
,:admin
,:editor
,:viewer
) have been implemented and tested