Strange behaviour for credential types #2854
Comments
|
In case this is also relevant - the image for the Hubtel Adaptor (above) is also not showing on the canvas (below)
|
|
Regarding the Gmail credential, it’s expected that it renders oddly. This happens because we need to configure an OAuth Client for it; without one, the system doesn’t recognize it as a valid OAuth Credential. Currently, the system parses its JSON Schema file to generate the form inputs. Since the JSON Schema includes an Access Token field, the system interprets this and renders an input for it. However, we don’t yet support generating OAuth credentials directly from the JSON Schema. While building that functionality is possible, for now, all OAuth credentials must be associated with an OAuth Client. @taylordowns2000 Would it be possible to create a Gmail OAuth Client? It sounds like a Google OAuth Client with these scopes: https://developers.google.com/identity/protocols/oauth2/scopes?hl=fr#gmail |
|
I just did these 3 guys and I could have the Hubtel icon nicely appear in my workflow and my credential types: - Hubtel Adaptor Icon
- Hubtel Credential Type
- Hubtel Credential Form
|
|
cc @jackohilts @taylordowns2000 see my comments above ! |
|
Hey Elias. Appreciate the reply. I think I did a bad job explaining the
bug. Let me give another go:
1. Yes, that’s all correct but how do we prevent it from appearing? What
steps will be taken to ensure that the “Gmail” option doesn’t appear in
that list? (It should not appear unless someone builds an OAurh client for
it.
2. Are you saying that maybe these steps failed to run properly when the
last docker image was built? What changes can you make that will ensure
that these steps are run before the next image is released? (Or, is it
possible that Hubtel was not yet published when the last image was released
and that’s why it’s not available? Please verify the timestamps on Hubtel
and the current release that’s on production.)
Taylor Downs
CEO, OpenFn <https://www.openfn.org>
…On Fri, Jan 24, 2025 at 02:08 Elias W. BA ***@***.***> wrote:
cc @jackohilts <https://github.com/jackohilts> @taylordowns2000
<https://github.com/taylordowns2000> see my comments above !
—
Reply to this email directly, view it on GitHub
<#2854 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCUBLMS6OSZNONK7KR5YUD2MGHALAVCNFSM6AAAAABVXBWH7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGMZTCNRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* fix: remove 'Gmail' from list for #2854" * update for Collections --------- Co-authored-by: Stuart Corbishley <[email protected]>
On
v2.10.12 (1.4.12)I'm seeing two strange things related to credentials:hubtelcredential type doesn't show up, despite a seemingly valid configuration schema existing here - this was generated directly by thepnpm generate <adaptor>command.gmailcredential type, despite gmail using Oauth. It asks the user to enter an access token manually, but access tokens are automatically generated via the Oauth flow.I have reproduced this locally on main:
To Reproduce Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: