Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssql Improve error logs #788

Merged
merged 4 commits into from
Oct 18, 2024
Merged

mssql Improve error logs #788

merged 4 commits into from
Oct 18, 2024

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Oct 16, 2024

Summary

Fix typo in changelog and log entire error message

Details

When the job fail on lightning the logs does not contain any useful information that could help with debugging, See example error message 👇🏽

T Failed step Upsert feedback table on Azure after 2.348s
R/T {
  "details": {},
  "message": "",
  "name": "AdaptorError",
  "severity": "fail",
  "source": "runtime"
}
R/T Check state.errors.b1de9d3b-ba65-49cf-8fff-147759b09736 for details.
R/T Run complete with status: fail
AdaptorError: unknown

This PR makes sure we log the whole error message when we have an error

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@mtuchi mtuchi marked this pull request as ready for review October 16, 2024 13:03
@josephjclark
Copy link
Collaborator

@mtuchi Does this actually fix the issue - do you get a better error report out?

If so you can bump versions and merge

@mtuchi mtuchi merged commit e8490cb into main Oct 18, 2024
2 checks passed
@mtuchi mtuchi deleted the mssql-error-logs branch October 18, 2024 10:18
@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 18, 2024

@josephjclark yes i have a better error report now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants