-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:implement dynamic request function in commcare #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple, great! Just a couple of little comments
We also need a changeset please! This is a minor
release because it adds a new function to the API
method: 'POST', | ||
data: form, | ||
}); | ||
|
||
return prepareNextState(state, response); | ||
return util.prepareNextState(state, response); | ||
} catch (e) { | ||
throw e.body ?? e; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for self @mtuchi
We should have a unit test for this throw e.body ?? e;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @hunterachieng
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
* feat: implement bulk upload for lookup-tables and case-data Signed-off-by: Hunter Achieng <[email protected]> * deleted imports not required Signed-off-by: Hunter Achieng <[email protected]> * fix: remove lookup-table plural Signed-off-by: Hunter Achieng <[email protected]> * reduce example and rename test Signed-off-by: Hunter Achieng <[email protected]> * update example Signed-off-by: Hunter Achieng <[email protected]> * remove try...catch Signed-off-by: Hunter Achieng <[email protected]> * fix bulk description Signed-off-by: Hunter Achieng <[email protected]> * implement changeset Signed-off-by: Hunter Achieng <[email protected]> * add unit test for bulk --------- Signed-off-by: Hunter Achieng <[email protected]> Co-authored-by: Emmanuel Evance <[email protected]>
ef0c656
to
f029ba9
Compare
@josephjclark i am merging this PR as it's blocking @hunterachieng , incase there is any feedback we can create an issue and open another PR |
Summary
Implement a generic
request
function incommcare
Details
We have many distinct APIs in commcare that can be used to make different requests. Since we cannot implement each separately, we have a generic function that will be used to make different requests.
Issues
#751
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.