feat:implement dynamic request function in commcare #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephjclark
requested changes
Sep 24, 2024
mtuchi
reviewed
Oct 1, 2024
mtuchi
reviewed
Oct 1, 2024
| method: 'POST', | ||
| data: form, | ||
| }); | ||
|
|
||
| return prepareNextState(state, response); | ||
| return util.prepareNextState(state, response); | ||
| } catch (e) { | ||
| throw e.body ?? e; |
There was a problem hiding this comment.
Note for self @mtuchi
We should have a unit test for this throw e.body ?? e;
mtuchi
approved these changes
Oct 1, 2024
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
* feat: implement bulk upload for lookup-tables and case-data Signed-off-by: Hunter Achieng <[email protected]> * deleted imports not required Signed-off-by: Hunter Achieng <[email protected]> * fix: remove lookup-table plural Signed-off-by: Hunter Achieng <[email protected]> * reduce example and rename test Signed-off-by: Hunter Achieng <[email protected]> * update example Signed-off-by: Hunter Achieng <[email protected]> * remove try...catch Signed-off-by: Hunter Achieng <[email protected]> * fix bulk description Signed-off-by: Hunter Achieng <[email protected]> * implement changeset Signed-off-by: Hunter Achieng <[email protected]> * add unit test for bulk --------- Signed-off-by: Hunter Achieng <[email protected]> Co-authored-by: Emmanuel Evance <[email protected]>
mtuchi
force-pushed
the
feat/commcare-request
branch
from
ef0c656
to
f029ba9
Compare
|
@josephjclark i am merging this PR as it's blocking @hunterachieng , incase there is any feedback we can create an issue and open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement a generic
requestfunction incommcareDetails
We have many distinct APIs in commcare that can be used to make different requests. Since we cannot implement each separately, we have a generic function that will be used to make different requests.
Issues
#751
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.