Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailgun: update to mailgun.js #341

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Mailgun: update to mailgun.js #341

merged 3 commits into from
Aug 10, 2023

Conversation

josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented Aug 9, 2023

Summary

Update mailgun.js so that we can resolve security vulnerabilities.

Details

This PR removes the deprecated mailgun-js package and replaces it with the latest mailgun.js.

This resolves security issues but does not change the user-facing API of the library.

Issues

Closes #325

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, has the migration tool been run and the
    migration guide followed?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

Copy link
Collaborator

@mtuchi mtuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍🏽

@mtuchi mtuchi merged commit 08c4691 into main Aug 10, 2023
1 check passed
@mtuchi mtuchi deleted the update-mailgun branch August 10, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailgun: use mailgun.js
2 participants