Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nexmo security patch #338

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Nexmo security patch #338

merged 3 commits into from
Aug 3, 2023

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Aug 3, 2023 •
edited
Loading

Summary

Removed unused packages and update nexmo package to use the latest version v2.9.1. Also add expandReferences on sendSMS params. Fixes #329

Review Checklist

  • Does the PR do what it claims to do?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@mtuchi mtuchi marked this pull request as ready for review August 3, 2023 14:41
josephjclark
josephjclark approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on expand references

@josephjclark josephjclark merged commit 0de4e6b into main Aug 3, 2023
1 check passed
@josephjclark josephjclark deleted the nexmo-security-patch branch August 3, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephjclark josephjclark josephjclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nexmo: update to 3.x
2 participants
@mtuchi @josephjclark