Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgraph cleanup state before throw #318

Merged
merged 4 commits into from
Jul 27, 2023
Merged

msgraph cleanup state before throw #318

merged 4 commits into from
Jul 27, 2023

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Jul 27, 2023

Summary

When catching an error on execute() i added a cleanup step then throw an error. Before that we were doing cleanup without throwing an error which made job code to pass even if there is a throw new Error() in that job code

Ref #319

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, has the migration tool been run and the
    migration guide followed?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@mtuchi mtuchi changed the title cleanup state before throw msgraph cleanup state before throw Jul 27, 2023
@mtuchi mtuchi requested a review from josephjclark July 27, 2023 09:33
@mtuchi mtuchi marked this pull request as ready for review July 27, 2023 09:33
@josephjclark josephjclark merged commit c0939dd into main Jul 27, 2023
1 check passed
@josephjclark josephjclark deleted the fix-msgraph-cleanup branch July 27, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants