Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common add expandReferences on parseCsv #308

Merged
merged 4 commits into from
Jul 14, 2023
Merged

common add expandReferences on parseCsv #308

merged 4 commits into from
Jul 14, 2023

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Jul 14, 2023 •
edited
Loading

Summary

Add expandReferences on parseCsv

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, has the migration tool been run and the
    migration guide followed?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@mtuchi mtuchi requested a review from josephjclark July 14, 2023 13:40
@mtuchi mtuchi marked this pull request as ready for review July 14, 2023 13:40
@josephjclark josephjclark merged commit e08f827 into main Jul 14, 2023
1 check passed
@josephjclark josephjclark deleted the parseCsv-expandReference branch July 14, 2023 13:54
josephjclark added a commit that referenced this pull request Jun 11, 2024
@josephjclark
Merge pull request #308 from OpenFn/pretty-logging
97cc9f3 
Pretty logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephjclark josephjclark josephjclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtuchi @josephjclark