Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop java 11 support #520

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Drop java 11 support #520

wants to merge 4 commits into from

Conversation

velo
Copy link
Member

@velo velo commented Aug 2, 2024

Most relevant libraries moved to java 17.

Hibernate is java17
JPA 3.2 spec is java17
Spring is java17

Time to move on

github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as duplicate.

@xeounxzxu
Copy link
Contributor

@velo
hello
Is JDK 17 official by default for this project?

@velo
Copy link
Member Author

velo commented Aug 8, 2024

Yes, both java 17 and 21 work fine.

This branch is more about dropping java 11 support.

Main motivation to do so is JPA 3.2 and make my life easier.

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@velo velo changed the title Preparing for java 17 prime time Drop java 11 support Aug 22, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 147-147
    • lines 500-503
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 16-15
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 24-23
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 147-147
    • lines 500-503
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 16-15
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 24-23
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 147-147
    • lines 500-503
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 16-15
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 24-23
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 147-147
    • lines 500-503
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 16-15
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 24-23
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 147-147
    • lines 501-502
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 16-15
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 24-23
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 147-147
    • lines 501-502
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 16-15
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 24-23
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

Copy link
Contributor

This pull request has been marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Oct 22, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 149-149
    • lines 503-504
  • querydsl-examples/pom.xml
    • lines 29-28
  • querydsl-examples/querydsl-example-jpa-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
    • lines 15-14
  • querydsl-examples/querydsl-example-jpa-spring/pom.xml
    • lines 12-11
  • querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
    • lines 11-10
  • querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
    • lines 13-12
  • querydsl-examples/querydsl-example-sql-guice/pom.xml
    • lines 16-15
  • querydsl-examples/querydsl-example-sql-spring/pom.xml
    • lines 13-12
  • querydsl-libraries/pom.xml
    • lines 40-39
  • querydsl-libraries/querydsl-collections/pom.xml
    • lines 15-14
  • querydsl-libraries/querydsl-core/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-guava/pom.xml
    • lines 13-12
  • querydsl-libraries/querydsl-jpa-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-jpa/pom.xml
    • lines 161-160
  • querydsl-libraries/querydsl-kotlin/pom.xml
    • lines 12-11
  • querydsl-libraries/querydsl-mongodb/pom.xml
    • lines 16-15
  • querydsl-libraries/querydsl-r2dbc/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-scala/pom.xml
    • lines 17-16
  • querydsl-libraries/querydsl-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-json/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spatial/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql-spring/pom.xml
    • lines 14-13
  • querydsl-libraries/querydsl-sql/pom.xml
    • lines 17-16
  • querydsl-tooling/pom.xml
    • lines 25-24
  • querydsl-tooling/querydsl-apt/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-codegen-utils/pom.xml
    • lines 19-18
  • querydsl-tooling/querydsl-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-jpa-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-kotlin-codegen/pom.xml
    • lines 14-13
  • querydsl-tooling/querydsl-ksp-codegen/pom.xml
    • lines 12-11
  • querydsl-tooling/querydsl-maven-plugin/pom.xml
    • lines 18-17
  • querydsl-tooling/querydsl-sql-codegen/pom.xml
    • lines 17-16

@velo velo added keep-open and removed Stale labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants