Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update javascript dependencies #326

Merged
merged 13 commits into from
Nov 1, 2023

Conversation

jannaahs
Copy link
Member

This will update all the javascript dependencies.

I've updated tailwindcss to the latest version and moved from the deprecated node-sass to sass.

No errors or warnings when building the frontend.

@jannaahs jannaahs added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 28, 2022
@jannaahs jannaahs self-assigned this Jun 28, 2022
@jannaahs jannaahs linked an issue Jun 28, 2022 that may be closed by this pull request
@knoxfighter
Copy link
Member

knoxfighter commented Jun 28, 2022

My plan is to update all dependencies to the latest MAJOR version. That will surely break things.
So please update that as well.

@jannaahs
Copy link
Member Author

My plan is to update all dependencies to the latest MAJOR version. That will surely break things. So please update that as well.

@knoxfighter Yeah, I wanted that as well. I tried to look into the MapGenerator again and noticed we could need an update of the dependencies.
I'll probably need some time to figure out why the github action is failing, because I can build the frontend locally. I just ask for the code review so you know about it and don't start doing it as well 😄

@knoxfighter
Copy link
Member

Ah, i see, could have created is as DraftPR :)
The npm failed previously for windows only, cause of the update to VS2022, but now that the ubuntu is failing, you have to look yourself.

@jannaahs
Copy link
Member Author

It seems to be related to tailwindcss. I'll have a look at it tomorrow or so.

@jannaahs
Copy link
Member Author

@knoxfighter you can now have a look at it.

@louisza
Copy link

louisza commented Sep 16, 2022

@knoxfighter is this ready to be pushed to the develop branch?

@knoxfighter
Copy link
Member

Writing it down now, since i currently have a look at it and will fix this the following weeks: The update of react-router from v5 to v6 changed the fundamentals completely, therefore i have to rewrite everything that does something with routes (which is most of it ...)

@knoxfighter
Copy link
Member

Writing it down now, since i currently have a look at it and will fix this the following weeks: The update of react-router from v5 to v6 changed the fundamentals completely, therefore i have to rewrite everything that does something with routes (which is most of it ...)

Wasn't that bad, got a working UI again now 🥳

@knoxfighter
Copy link
Member

If anybody wants to have another look, i would love the feedback.
In either case, i will merge this PR on Tuesday.

@Mattie112
Copy link
Contributor

I can try it out but not before the weekend :) But we can always test in production ;)

@knoxfighter
Copy link
Member

@Mattie112 I merge this PR now, i would love if you test the changes on the develop branch. You can either answer here, in a new issue, or on our discord, thank you :)

@knoxfighter knoxfighter merged commit e896972 into develop Nov 1, 2023
14 of 22 checks passed
@knoxfighter knoxfighter deleted the 324-update-javascript-dependencies branch November 1, 2023 22:03
@Mattie112
Copy link
Contributor

Did not notice any issues 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all JavaScript dependencies
4 participants