Removed circular call where the core library calls itself instead of the plugins #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using plugins directly. Signed-off-by: Christian Pinto <[email protected]> Signed-off-by: Christian Pinto <[email protected]>
|
Looking
From: Christian Pinto ***@***.***>
Date: Thursday, August 8, 2024 at 2:05 AM
To: OpenFabrics/sunfish_library_reference ***@***.***>
Cc: Aguilar, Michael James ***@***.***>, Mention ***@***.***>
Subject: [EXTERNAL] Re: [OpenFabrics/sunfish_library_reference] Removed circular call where the core library calls itself instead of the plugins (PR #32)
@mjaguil<https://github.com/mjaguil> @cayton<https://github.com/cayton> Could you have a quick look at this PR?
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEGDPAHXSOSIHGFIMPZQQMDZQMRCNAVCNFSM6AAAAABLQT7FHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGIYDENZQGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Nevermind…. Stupid 2-factor, I’ll have to get to it, later today
I can’t have my cell phone with me
From: Christian Pinto ***@***.***>
Date: Thursday, August 8, 2024 at 2:05 AM
To: OpenFabrics/sunfish_library_reference ***@***.***>
Cc: Aguilar, Michael James ***@***.***>, Mention ***@***.***>
Subject: [EXTERNAL] Re: [OpenFabrics/sunfish_library_reference] Removed circular call where the core library calls itself instead of the plugins (PR #32)
@mjaguil<https://github.com/mjaguil> @cayton<https://github.com/cayton> Could you have a quick look at this PR?
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEGDPAHXSOSIHGFIMPZQQMDZQMRCNAVCNFSM6AAAAABLQT7FHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGIYDENZQGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
mjaguil
reviewed
Aug 12, 2024
mgazz
approved these changes
Aug 12, 2024
@mjaguil is the review approved? I can't really understand what this comment is about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using plugins directly.