Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically attach the required files to releases #1956

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ColinHDev
Copy link
Contributor

Summary of the discussion

As described in #1955, the Release workflow currently requires that an oeo-closure.owl file present in the build-files.zip artifact to be attached to a release. However that pull request would remove said file from the artifacts for a reduced completion time of workflow runs.

This Pr tries to automate the release workflow. Instead of a maintainer going to the workflow artifacts of two separate runs to download the build-files.zip and existing-terms-and-definitions.zip and create a release with them, the maintainer would now only have to write and publish the release and this workflow would then automatically attach said files.

However, I am not really able to test this easily. But even if the automation fails, this pr ensures that a version of build-files.zip is uploaded that contains the oeo-closure.zip file, so the maintainer can add it automatically.

Type of change (CHANGELOG.md)

---

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@ColinHDev ColinHDev requested a review from stap-m October 20, 2024 23:04
@stap-m stap-m requested a review from jh-RLI October 21, 2024 06:37
@stap-m
Copy link
Contributor

stap-m commented Oct 21, 2024

@jh-RLI could you please also take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

2 participants