Add task definition in separate module #1891 #1940

madbkr · 2024-10-07T12:36:21Z

Summary of the discussion

In an effort to add energy-related task definitions I added a separate module called oeo-tasks and tried to implement the needed classes as proposed in #1891. The module is not yet imported by the oeo. There are still some questions open as seen in the issue.

Type of change (CHANGELOG.md)

Add

new file oeo-tasks.omn for all of the changes proposed. This would be a separate module to the current oeo.

Added classes:

All the subtasks of a task as a subclasses of action specification. For better readability they get their own parent class.

'action specification for available area for wind farm development'
- 'acquisition and processing datasets for exclusion criteria'
- 'determine area for development'
- 'determine geographical potential'
- 'determine MCDA approach for soft exclusion criteria'
- 'interpolate wind data to greater resolution horizontally'
- 'select exclusion criteria and buffer distances'

'action specification for for the technical wind potential'
- 'account for wake losses'
- 'calculate technical potential'
- 'determine capacity factor (CF)'
- 'place turbines in area or determine capacity density'
- 'select appropriate turbine type(s)'
- 'use power curve with wind distribution function to determine annual energy yield'

'action specification for techno-economic potential'
- 'calculate economic potential for LCOE range'
- 'calculate Levelized Cost of Energy (LCOE)'
- 'determine discount & interest rate'
- 'determine investment costs'
- 'determine operating and maintenance costs'
- 'determine wind turbine lifetime'

'action specification for the feasible potential'
- 'apply additional social/market constraints'
- 'calculate feasible potential for the region'

'action specification for wind characteristics'
- data acquisition and pre-processing
- extrapolate wind speed vertically to hub height
- account for air density change
- determine wind speed frequency distribution
- determine seasonal/diurnal variability
- determine the theoretical potential / WPD

Headline of the task as subclass of objective specification
- determined wind characteristics of a region
- 'determined available area for wind farm development'
- 'determined feasible potential'
- 'determined the technical wind potential of the available area'
- 'determined the techno-economic potential of the available region'
Headline of the task + method as a subclass of methodology
- determination method for wind characteristics of a region
- 'determination method for the available area for wind farm development'
- 'determination method for the feasible potential'
- 'determination method for the technical wind potential of the available area'
- 'determination method for the techno-economic potential of the available region'
As a subclass of process
- determination process for wind characteristics of a region
- 'determination process for the available area for wind farm development'
- 'determination process for the feasible potential'
- 'determination process for the technical wind potential of the available area'
- 'determination process for the techno-economic potential of the available region'

Added axioms:

For determination method for wind characteristics of a region
- 'has part' some 'determined wind characteristics of a region'
For 'determination method for the available area for wind farm development'
- 'has part' some 'determined available area for wind farm development'
For 'determination method for the feasible potential'
- 'has part' some 'determined feasible potential'
For 'determination method for the technical wind potential of the available area'
- 'has part' some 'determined the technical wind potential of the available area'
For 'determination method for the techno-economic potential of the available region'
- 'has part' some 'determined the techno-economic potential of the available region'
For determination process for wind characteristics of a region
- 'structured by' some 'determination method for wind characteristics of a region'
For 'determination process for the available area for wind farm development'
- 'structured by' some 'determination method for the available area for wind farm development'
For 'determination process for the feasible potential'
- 'structured by' some 'determination method for the feasible potential'
For 'determination process for the technical wind potential of the available area'
- 'structured by' some 'determination method for the technical wind potential of the available area'
For 'determination process for the techno-economic potential of the available region'
- 'structured by' some 'determination method for the techno-economic potential of the available region'

Added Object Properties

As a subclass of has participant
- structured by

Workflow checklist

Automation

Closes #

PR-Assignee

🐙 Follow the Pull Request Workflow
📝 Update the CHANGELOG.md
📙 Add #'s to term tracker item

Reviewer

🐙 Follow the Reviewer Guide
🐙 Provided feedback and show sufficient appreciation for the work done

madbkr · 2024-10-07T14:13:57Z

@stap-m
Could you please let me know if this is what you had in mind? If not I'd like to correct my mistakes before I implement the other tasks.

Also it seems like I made a mistake and branched from my last feature (the small correction in the PR template) instead of from dev. I could use git revert but am unsure if that will cause even more problems when merging later. Any advice?

stap-m · 2024-10-08T08:57:24Z

Also it seems like I made a mistake and branched from my last feature (the small correction in the PR template) instead of from dev. I could use git revert but am unsure if that will cause even more problems when merging later. Any advice?

No worries. You can merge dev into this branch. This will probably cause merge conflicts, too, though.

stap-m · 2024-10-08T09:56:41Z

Could you please let me know if this is what you had in mind? If not I'd like to correct my mistakes before I implement the other tasks

Yes, it goes into the right direction. But lets focus on the first tasks for now. I have some general remarks:

In general, especially for such a complex changes, please document your changes in the PR header a more detailed, such that I can directly see what you did (wanted to do)

which new class is of which kind, group the different types, ...
adding a new file(!)
complex axioms
...

I'd recommend to discuss definitions and axioms in the issue first.

For the definitions, please use the Aristotelian schema "A xxx is a yyy that zzz". E.g. "An account for air density change is a ... ".

I not yet sure whether we actually need the relations that you added, they were rather for illustrating the complex model. That's why I used dashed lines. Sorry for not mentioning that.

madbkr · 2024-10-08T10:18:34Z

@stap-m
Thank you for your answer.

In general, especially for such a complex changes, please document your changes in the PR header a more detailed, such that I can directly see what you did (wanted to do)

I was going to do that before converting the draft to a proper pull request. But now I know a lot more about what to write, so thank you.

I'd recommend to discuss definitions and axioms in the issue first.

Alright, then I'll move all the stuff I did there and wait for feedback.

For the definitions, please use the Aristotelian schema "A xxx is a yyy that zzz". E.g. "An account for air density change is a ... ".

I did try to do that. I really did. I'll go over them again.

I not yet sure whether we actually need the relations that you added, they were rather for illustrating the complex model. That's why I used dashed lines. Sorry for not mentioning that.

I thought they made everything more understandable but I am ready to remove them. I will move this question to the issue.

…module

…eperate-module" This reverts commit 2ce72e0, reversing changes made to ab67ed1.

…module

LillyG901

Looks pretty good to me (except for the small changes I suggested).
I'm not sure how important the period at the end of a definiton is. If it isn't you may ignore those annotations. I just pointed them out for consistency.

I do have an issue however: When opening the files in Protege I still see the old (non Aristotlean) definitions, no task trackers and some axioms are missing.
These things do look correct within the file,
I'm not sure if this is an issue on my end, so I'd like for someone else to take a look.

src/ontology/edits/oeo-tasks.omn

LillyG901 · 2024-10-20T15:53:55Z

src/ontology/edits/oeo-tasks.omn

+        OEO_00020426 "Add:
+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "A relationship between a process and a plan specification, in which the process is predefined or planned by the process.",


I am slightly confused by the wording of this definiton. Is it intended, that it says 'process is predefined or planned by the process' or should the second process be plan specification?

Thank you for noticing! I fixed it.

src/ontology/edits/oeo-tasks.omn

Co-authored-by: LillyG901 <[email protected]>

src/ontology/edits/oeo-tasks.omn

Co-authored-by: stap-m <[email protected]>

stap-m · 2024-10-21T08:22:39Z

I have two general remarks:

I am wondering for all these cases with the long labels, whether the definitions would read more smoothly if they started with "A" (indefinite article)). Currently, they start directly with the label, which is also ok in the Aristotelian style.
Many/most of the action specification labels sound like processes, e.g. data acquisition and pre-processing. We usually try to avoid that. That could be done by adding the word "action" of "method". However, this would make the labels even more clumsy.

Any opinions @madbkr @LillyG901

stap-m · 2024-10-21T08:29:36Z

src/ontology/edits/oeo-tasks.omn

+        OEO_00020426 "Add:
+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "Determined wind characteristics of a region is an object specification that defines the goal of a process as a state of understanding the specific wind characteristics of a predefined region.",


Suggested change

<http://purl.obolibrary.org/obo/IAO_0000115> "Determined wind characteristics of a region is an object specification that defines the goal of a process as a state of understanding the specific wind characteristics of a predefined region.",

<http://purl.obolibrary.org/obo/IAO_0000115> "Determined wind characteristics of a region is an object specification that defines the goal of a methodology as a state of understanding the specific wind characteristics of a predefined region.",

I'd argue that the object specification is the goal of the plan specificaton or methodology respectively, not the process. I think, the process has not goal itself.
Please check for all object specifications @madbkr

Yeah, that sounds more reasonable. I will change it.

stap-m · 2024-10-21T08:32:36Z

src/ontology/edits/oeo-tasks.omn

+        OEO_00020426 "Add:
+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows some kind of methodology to gain knowledge of the specific wind characteristics of a predefined region.",


Suggested change

<http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows some kind of methodology to gain knowledge of the specific wind characteristics of a predefined region.",

<http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows some kind of methodology to gain knowledge of the specific wind characteristics of a predefined region.",

Suggested change

<http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows some kind of methodology to gain knowledge of the specific wind characteristics of a predefined region.",

<http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows a determination methodology for wind characteristics, to gain knowledge of the specific wind characteristics of a predefined region.",

It is a very specific methodology, not just "some kind", right?

alright, updated for all the processes

madbkr · 2024-10-21T08:35:30Z

@stap-m
I don't think the lables necessarily sound like processes but their length is very uncomfortable. It sounds more like a sentence than a name.
If I had not used the given names I probably would have used a summarizing name for a task. For example
Data preparation and included in the definition that this is about acquisition and pre-processing.

stap-m · 2024-10-22T06:59:28Z

@stap-m I don't think the lables necessarily sound like processes but their length is very uncomfortable. It sounds more like a sentence than a name. If I had not used the given names I probably would have used a summarizing name for a task. For example Data preparation and included in the definition that this is about acquisition and pre-processing.

I like the idea. If you can find more meaningful labels that summarize the content, we could add either the shorend or the long ones as alternative labels.
EDIT: Please propose them in the issue first before committing.

src/ontology/edits/oeo-tasks.omn

stap-m · 2024-10-22T07:14:20Z

src/ontology/edits/oeo-tasks.omn

+        OEO_00020426 "Add:
+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows a determination methodology for wind characteristics to gain knowledge of the specific wind characteristics of a predefined region.",


Suggested change

<http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows a determination methodology for wind characteristics to gain knowledge of the specific wind characteristics of a predefined region.",

<http://purl.obolibrary.org/obo/IAO_0000115> "Determination process for wind characteristics of a region is a process that follows a determination methodology for wind characteristics to gain knowledge of the specific wind characteristics of a predefined region.",

Please add to to do list in Issue:
add axiom to study region/region of relevance. Maybe harmonize the wording in the definitions, too.

stap-m · 2024-10-22T07:20:52Z

src/ontology/edits/oeo-tasks.omn

+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "Determine seasonal/diurnal variability is an action specification that describes the process of identifying variations in wind characteristics across different seasons and times of day.",
+        rdfs:label "determine seasonal/diurnal variability"@en


Suggested change

rdfs:label "determine seasonal/diurnal variability"@en

rdfs:label "determine seasonal/diurnal wind variability"@en

The label should refer to wind somehow. Please also change in the definition.

stap-m · 2024-10-22T07:29:30Z

src/ontology/edits/oeo-tasks.omn

+        OEO_00020426 "Add:
+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "Determine the theoretical potential / WPD is an action specification that describes how Wind Power Density (WPD) is calculated to estimate the theoretical wind power potential based on wind speed and air density.",


Suggested change

<http://purl.obolibrary.org/obo/IAO_0000115> "Determine the theoretical potential / WPD is an action specification that describes how Wind Power Density (WPD) is calculated to estimate the theoretical wind power potential based on wind speed and air density.",

<http://purl.obolibrary.org/obo/IAO_0000115> "Determine the theoretical wind power potential / wind power density is an action specification that describes how wind power density (WPD) is calculated to estimate the theoretical wind power potential based on wind speed and air density.",

Please add to to do list in Issue:
We have something like theoretical potential and maybe also wind power density in the OEO. We should add axioms in a later step (OEO_00140063).

stap-m · 2024-10-22T07:35:11Z

src/ontology/edits/oeo-tasks.omn

+        OEO_00020426 "Add:
+issue: https://github.com/OpenEnergyPlatform/ontology/issues/1891
+pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1940",
+        <http://purl.obolibrary.org/obo/IAO_0000115> "Determine MCDA approach for soft exclusion criteria is an action specification that describes how a Multi-Criteria Decision Analysis (MCDA) method is applied to areas where exclusions are not absolute, allowing for weighted decision-making",


Add MCDA as separate concept?

madbkr · 2024-10-22T08:12:11Z

@stap-m I don't think the lables necessarily sound like processes but their length is very uncomfortable. It sounds more like a sentence than a name. If I had not used the given names I probably would have used a summarizing name for a task. For example Data preparation and included in the definition that this is about acquisition and pre-processing.

I like the idea. If you can find more meaningful labels that summarize the content, we could add either the shorend or the long ones as alternative labels. EDIT: Please propose them in the issue first before committing.

Alright, I will try to come up with better lables for all of the tasks and propose adjusted definitions.

Co-authored-by: stap-m <[email protected]>

madbkr added 3 commits October 7, 2024 12:33

Add new module

02f1959

Add experimental implementation for first task

be725c9

Add provisional definitions

65bb1c8

madbkr self-assigned this Oct 7, 2024

stap-m mentioned this pull request Oct 8, 2024

Please add energy-related task definitions in the OEO #1891

Open

madbkr added 5 commits October 8, 2024 13:25

Change definition of determined wind characteristics

77116af

Update definitions

3f97253

Remove new relations

7eb5dd6

Update changelog

ab67ed1

Merge branch 'dev' into feature-1891-add-task-definition-in-seperate-…

2ce72e0

…module

madbkr changed the title ~~Add task definition in seperate module #1891~~ Add task definition in separate module #1891 Oct 11, 2024

madbkr and others added 15 commits October 11, 2024 11:34

Revert "Merge branch 'dev' into feature-1891-add-task-definition-in-s…

dc2f994

…eperate-module" This reverts commit 2ce72e0, reversing changes made to ab67ed1.

Add new object properties

1bddad8

Merge branch 'dev' into feature-1891-add-task-definition-in-seperate-…

261a4fb

…module

Update definitions

ac779e0

Update definition and remove axiom

67c6b3c

Update definitions

0fe0deb

Remove unused relation

81724d8

Add second task

d9ac4c2

Add third task

637cacb

Add forth task

1fbe45e

Add fifth task and missing annotation

41e56dc

Merge branch 'dev' into feature-1891-add-task-definition-in-seperate-…

6279094

…module

Remove unclear axioms

7fd5194

Update changelog

5babf4f

Merge branch 'dev' into feature-1891-add-task-definition-in-seperate-…

7255dac

…module

madbkr requested a review from stap-m October 18, 2024 09:28

stap-m requested review from NormanZielke, LillyG901, ColinHDev and p-kuckertz October 18, 2024 12:05

LillyG901 reviewed Oct 20, 2024

View reviewed changes

stap-m and others added 10 commits October 21, 2024 09:52

Update src/ontology/edits/oeo-tasks.omn

38f33ae

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

413ad96

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

0c45c86

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

a472847

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

9416320

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

1bf59e9

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

51bf7a4

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

7e23191

Co-authored-by: LillyG901 <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

dc0f752

Co-authored-by: LillyG901 <[email protected]>

Update definition

0b9542d

stap-m reviewed Oct 21, 2024

View reviewed changes

src/ontology/edits/oeo-tasks.omn Outdated Show resolved Hide resolved

src/ontology/edits/oeo-tasks.omn Outdated Show resolved Hide resolved

src/ontology/edits/oeo-tasks.omn Outdated Show resolved Hide resolved

madbkr and others added 2 commits October 21, 2024 10:20

Update src/ontology/edits/oeo-tasks.omn

a3252b4

Co-authored-by: stap-m <[email protected]>

Update src/ontology/edits/oeo-tasks.omn

185c2a2

Co-authored-by: stap-m <[email protected]>

stap-m reviewed Oct 21, 2024

View reviewed changes

madbkr added 2 commits October 21, 2024 10:59

Update definitions

7e1ebb8

Update definitions

b6e2de4

stap-m reviewed Oct 22, 2024

View reviewed changes

madbkr and others added 2 commits October 22, 2024 10:13

Update src/ontology/edits/oeo-tasks.omn

3751313

Co-authored-by: stap-m <[email protected]>

Update definitions as suggested

857df4d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add task definition in separate module #1891 #1940

Add task definition in separate module #1891 #1940

madbkr commented Oct 7, 2024 •

edited

Loading

madbkr commented Oct 7, 2024

stap-m commented Oct 8, 2024

stap-m commented Oct 8, 2024

madbkr commented Oct 8, 2024 •

edited

Loading

LillyG901 left a comment

LillyG901 Oct 20, 2024

madbkr Oct 21, 2024

stap-m commented Oct 21, 2024

stap-m Oct 21, 2024

madbkr Oct 21, 2024

stap-m Oct 21, 2024

madbkr Oct 21, 2024

madbkr commented Oct 21, 2024

stap-m commented Oct 22, 2024 •

edited

Loading

stap-m Oct 22, 2024

stap-m Oct 22, 2024

stap-m Oct 22, 2024

stap-m Oct 22, 2024

madbkr commented Oct 22, 2024

	<http://purl.obolibrary.org/obo/IAO_0000115> "Determined wind characteristics of a region is an object specification that defines the goal of a process as a state of understanding the specific wind characteristics of a predefined region.",
	<http://purl.obolibrary.org/obo/IAO_0000115> "Determined wind characteristics of a region is an object specification that defines the goal of a methodology as a state of understanding the specific wind characteristics of a predefined region.",

	rdfs:label "determine seasonal/diurnal variability"@en
	rdfs:label "determine seasonal/diurnal wind variability"@en

Add task definition in separate module #1891 #1940

Are you sure you want to change the base?

Add task definition in separate module #1891 #1940

Conversation

madbkr commented Oct 7, 2024 • edited Loading

Summary of the discussion

Type of change (CHANGELOG.md)

Add

Workflow checklist

Automation

PR-Assignee

Reviewer

madbkr commented Oct 7, 2024

stap-m commented Oct 8, 2024

stap-m commented Oct 8, 2024

madbkr commented Oct 8, 2024 • edited Loading

LillyG901 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stap-m commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madbkr commented Oct 21, 2024

stap-m commented Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madbkr commented Oct 22, 2024

madbkr commented Oct 7, 2024 •

edited

Loading

madbkr commented Oct 8, 2024 •

edited

Loading

stap-m commented Oct 22, 2024 •

edited

Loading