Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Axioms to energy subclasses #1600 #1620

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

nelekoehler
Copy link
Contributor

Summary of the discussion

Added the following axioms:
'wind energy' 'has bearer' some air
'hydro energy' 'has bearer' some water
'solar energy' 'has bearer' some photon

Type of change (CHANGELOG.md)

Updated

Workflow checklist

Automation

Closes #1600

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@nelekoehler nelekoehler self-assigned this Jul 13, 2023
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Jul 13, 2023
@nelekoehler nelekoehler marked this pull request as ready for review July 13, 2023 13:39
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: stap-m <[email protected]>
@nelekoehler nelekoehler merged commit 9554807 into dev Jul 17, 2023
3 checks passed
@nelekoehler nelekoehler deleted the feature-1600-add-relations-to-energy-subclasses branch July 17, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relations between energy subclasses and its bearers
2 participants