Try to be slightly more friendly to people on outdated operating systems. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should prevent people on older versions of OS X being prompted to update.
clobber
added a commit
that referenced
this pull request
Dec 30, 2015
Try to be slightly more friendly to people on outdated operating systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparkle supports the
<sparkle:minimumSystemVersion>key for avoiding serving updates that will break compatibility. However, the way the emulator core updater works in OE, this key is ignored for cores. Users are only protected from updating OE itself, and can easily update cores to incompatible versions (which crash OE 1.0.4 when it tries to load them).Sparkle unfortunately only implements version checking logic in its frontend, not its backend, I assume because it's terrible.This is actually false, something weird is happening, and the logic is being ignored.I think least disruptive way to fix this is to park modified versions of
oecores.xmlandoecores-experimental.xmlon a separate branch, and then change the plist value ofOECoreListURLto point to those modified versions. These modified versions would point to older versions of the appcasts (by pointing at a specific revision in this repo). However, this would require modifying the plist and re-uploading the OE 1.0.4 binaries. This wouldn't protect users with the current version of 1.0.4 installed, but it would allow people to safely (re)install 1.0.4 from scratch, which can only currently be done by manually downloading each core from github.This PR also cleans up mixed tab/space indentation.