Fix showing temp4 #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into elecrow_esp32_hmi
temp4 assignment was incorrectly using the status_store.temp3.isNaN check. Signed-off-by: Kir Kolyshkin <[email protected]>
To simplify things and avoid typos like the one fixed in the previous commit. Signed-off-by: Kir Kolyshkin <[email protected]>
jeremypoulter
changed the title
Closed
…into pr/kolyshkin/97
Merged
|
Replaced by #125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #96 but for the branch used in
openevse_wifi_tft_v1. Original description follows.The first commit fixes the issue, and the second one makes sure it won't happen again.
temp4assignment was incorrectly using thetemp3.isNaNcheck.Introduce/use
temp_round()to show temperatures, to simplify things and avoid typos like the one fixed in the previous commit.