Feature/graphic compare bydate #2988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Also make it work before you provide a PR please as right now it does not even compile correctly. Greetings |
Sn0w3y
reviewed
Jan 24, 2025
| <!-- Form to select periods --> | ||
| <form (ngSubmit)="onComparePeriods()"> | ||
| <div class="form-group"> | ||
| <label for="period1">Période 1:</label> |
There was a problem hiding this comment.
Fixed Language needs to be changed to translate.
| } | ||
|
|
||
| Promise.all([ | ||
| this.service.getDataForDate(this.date1), |
There was a problem hiding this comment.
getDataForDate does not exist on the branch
| this.service.getDataForDate(this.date2), | ||
| ]).then(([data1, data2]) => { | ||
| const comparisonData = this.getComparisonChartData(this.date1, this.date2, this.period1, this.period2); | ||
| this.datasets = comparisonData.output; |
There was a problem hiding this comment.
Type '(data: ChannelData, labels?: (string | Date)[]) => DisplayValue[]' is not assignable to type 'ChartDataset<keyof ChartTypeRegistry, (number | Point | [number, number] | BubbleDataPoint)[]>[]'.ts(2322)
|
Hello, Thank you for your comments. I am trying to fix it .. Greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses issue #2907. In the Chart component, I propose a solution to compare dates between two periods.
Changes Made
Added logic to allow comparison of dates between two specified periods within the Chart component.