Modbus: AbstractReadTask: Enhance Parsing Response; exception catch #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #2879 +/- ##
=============================================
+ Coverage 57.31% 57.34% +0.03%
- Complexity 9156 9163 +7
=============================================
Files 2177 2177
Lines 92873 92873
Branches 6883 6883
=============================================
+ Hits 53221 53245 +24
+ Misses 37701 37680 -21
+ Partials 1951 1948 -3
|
|
@DerStoecki Could you please add an appropriate Junit Testcase, so that Codecov runs through. |
More generic catch block for more detailed channel assignment errors. E.g. the original code is not able to catch the following kind of errors: [modbus1 ] ERROR [dbus.api.task.AbstractReadTask] Parsing Response failed. IllegalArgumentException: Unable to set value [-4395165653183430656] for Channel [battery0/ChrW]: Cannot convert. Long [-4395165653183430656] is not fitting in Integer range. This kind of messages would have been very helpful for detecting channel mapping errors, but it is not catched by OpenemsException
Trigger IllegalArgumentException by adding a new Channel, and filling it with Integer.MAX value (not fitting in short range), catch the log and check for "IllegalArgumentException" -> For me : easiest way to catch the logError
DerStoecki
force-pushed
the
feature/ModbusTaskGenericExceptionCatch
branch
from
0547606 to
10d2953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More generic catch block for more detailed channel assignment errors. E.g. the original code is not able to catch the following kind of errors:
This kind of messages would have been very helpful for detecting channel mapping errors, but it is not catched by OpenemsException