Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Masonry layout for widgets #2845

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

da-Kai
Copy link
Contributor

@da-Kai da-Kai commented Oct 18, 2024

Aktuell

Bildschirmfoto am 2024-10-18 um 18 02 25

Masonry Layout

Bildschirmfoto am 2024-10-18 um 18 01 06

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2845      +/-   ##
=============================================
- Coverage      57.32%   57.30%   -0.01%     
+ Complexity      9159     9154       -5     
=============================================
  Files           2177     2177              
  Lines          92873    92879       +6     
  Branches        6883     6883              
=============================================
- Hits           53227    53217      -10     
- Misses         37698    37711      +13     
- Partials        1948     1951       +3     
---- 🚨 Try these New Features:

@da-Kai
Copy link
Contributor Author

da-Kai commented Oct 25, 2024

@lukasrgr
Ich hab die Implementierung jetzt so geändert, dass die reihenfolge gleich bleibt

openems-masonry

@Sn0w3y
Copy link
Contributor

Sn0w3y commented Nov 15, 2024

Just a little Information for you @da-Kai - I tried this and it basically scrumbled up sometimes all Widgets as they got rendered too slow because of the slower Channel Population of some Components - either we need to increase the Timeout here:

https://github.com/OpenEMS/openems/pull/2845/files#diff-b001e10dc95932dfad86e0e988df71e34fafc7fa94c3457d65707af3d19f8a07R49

or find another solution for it i guess ? :)

Edit: The CSS does not get applied correctly if the Container is getting bigger after Channel Population. This leads to Overlapping Cards for example. I also got it from time to Time, that the Cards were just above each other on the top left upper corner, where nothing could be seen anymore. JFYI

Greetings !

Copy link
Contributor

@lukasrgr lukasrgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not approve it like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants