Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min support for PCAL6416A #1

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Min support for PCAL6416A #1

merged 1 commit into from
Jan 10, 2025

Conversation

madeleyneVaca
Copy link
Contributor

Provides support to set pin direction (input, output) and output pin level

@madeleyneVaca madeleyneVaca force-pushed the mavaca/io_exp_min_support branch 2 times, most recently from dd936b7 to 38d3bbb Compare January 8, 2025 19:08
@jerrysxie jerrysxie added the enhancement New feature or request label Jan 8, 2025
felipebalbi
felipebalbi requested changes Jan 8, 2025
View reviewed changes
felipebalbi
felipebalbi reviewed Jan 8, 2025
View reviewed changes
@madeleyneVaca madeleyneVaca force-pushed the mavaca/io_exp_min_support branch from 38d3bbb to b18b530 Compare January 8, 2025 22:01
@felipebalbi
Copy link
Contributor

Looks good now, but please fix the failed workflows. Looks like you need to add a couple licenses to deny.toml and run cargo +nightly fmt.

jerrysxie
jerrysxie approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jerrysxie jerrysxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some unit tests for this driver as well like in this PR: OpenDevicePartnership/bq40z50#7.

@madeleyneVaca madeleyneVaca force-pushed the mavaca/io_exp_min_support branch from b18b530 to 2354094 Compare January 9, 2025 00:23
@madeleyneVaca madeleyneVaca mentioned this pull request Jan 9, 2025
Open
@felipebalbi
Copy link
Contributor

Looks like MSRV needs to be raised because of device-driver dependency.

@jerrysxie
Copy link
Contributor

We should add some unit tests for this driver as well like in this PR: pop-project/bq40z50#7.

Please add an issue for adding unit test as well. That can be a good starting issue for new developers as well.

@madeleyneVaca
Initial commit for PCAL6416A
a146a50 
Provides support to set pin direction (input, output) and output pin level
@madeleyneVaca madeleyneVaca force-pushed the mavaca/io_exp_min_support branch from 2354094 to a146a50 Compare January 10, 2025 04:08
@jerrysxie jerrysxie requested a review from felipebalbi January 10, 2025 04:45
@madeleyneVaca madeleyneVaca mentioned this pull request Jan 10, 2025
Open
@madeleyneVaca
Copy link
Contributor Author

We should add some unit tests for this driver as well like in this PR: pop-project/bq40z50#7.

Please add an issue for adding unit test as well. That can be a good starting issue for new developers as well.

#3

felipebalbi
felipebalbi approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@felipebalbi felipebalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, @madeleyneVaca 🥇

@jerrysxie jerrysxie merged commit 2f2202d into OpenDevicePartnership:main Jan 10, 2025
9 checks passed
@felipebalbi felipebalbi deleted the mavaca/io_exp_min_support branch January 10, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrysxie jerrysxie jerrysxie approved these changes

@felipebalbi felipebalbi felipebalbi approved these changes

@huseinmsft huseinmsft huseinmsft approved these changes

Assignees

@madeleyneVaca madeleyneVaca

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madeleyneVaca @felipebalbi @jerrysxie @huseinmsft