Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espi: Mark W1C bits accordingly #7

Merged

Conversation

felipebalbi
Copy link
Contributor

These bits are Write-1-to-clear, let's mark them accordingly so svd2rust generates the correct accessors for us.

These bits are Write-1-to-clear, let's mark them accordingly so
svd2rust generates the correct accessors for us.
@felipebalbi felipebalbi added the bug Something isn't working label Jan 7, 2025
@felipebalbi felipebalbi requested a review from Copilot January 7, 2025 15:56
@felipebalbi felipebalbi self-assigned this Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/espi/mstat.rs:8

  • [nitpick] The type name P80intR is inconsistent with the naming convention. It should be renamed to P80IntR.
pub type P80intR = crate::BitReader;
@felipebalbi felipebalbi merged commit 7433e41 into OpenDevicePartnership:main Jan 7, 2025
9 checks passed
@felipebalbi felipebalbi deleted the espi-mstat-w1c-bits branch January 7, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant