Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch ADC RESFIFO field D and remove reference to 632 #13

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Patch ADC RESFIFO field D and remove reference to 632 #13

merged 3 commits into from
Feb 3, 2025

Conversation

jerrysxie
Copy link
Contributor

  • Remove lower 3 bits as it is not used and always 0

@jerrysxie jerrysxie added the enhancement New feature or request label Feb 2, 2025
@jerrysxie jerrysxie requested a review from felipebalbi February 2, 2025 04:17
@jerrysxie jerrysxie self-assigned this Feb 2, 2025
@jerrysxie jerrysxie marked this pull request as ready for review February 2, 2025 04:23
jerrysxie
jerrysxie commented Feb 2, 2025
View reviewed changes
felipebalbi
felipebalbi requested changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@felipebalbi felipebalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Nice, few little things to fix. I believe the same patch can be applied on both PACs?

@jerrysxie jerrysxie force-pushed the patch_adc_resfifo_d_field branch from 127633c to bf6bbae Compare February 2, 2025 20:47
@jerrysxie jerrysxie changed the title Patch ADC RESFIFO field D Patch ADC RESFIFO field D and remove reference to 632 Feb 2, 2025
@jerrysxie jerrysxie force-pushed the patch_adc_resfifo_d_field branch from bf6bbae to 2708f10 Compare February 3, 2025 16:43
felipebalbi
felipebalbi requested changes Feb 3, 2025
View reviewed changes
@jerrysxie jerrysxie force-pushed the patch_adc_resfifo_d_field branch from 2708f10 to 33c9826 Compare February 3, 2025 22:46
@jerrysxie jerrysxie force-pushed the patch_adc_resfifo_d_field branch from 33c9826 to 28b9314 Compare February 3, 2025 22:50
@jerrysxie jerrysxie requested a review from felipebalbi February 3, 2025 22:50
@felipebalbi felipebalbi merged commit f7d1001 into OpenDevicePartnership:main Feb 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipebalbi felipebalbi felipebalbi approved these changes

Assignees

@jerrysxie jerrysxie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerrysxie @felipebalbi