Initial work #2
Annotations
2 errors and 1 warning
cargo clippy:
src/lib.rs#L59
[clippy] reported by reviewdog 🐶
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/lib.rs:59:1
|
59 | impl<T, BE> Into<Result<T, Error<BE>>> for PdError {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-F clippy::from-over-into` implied by `-F clippy::style`
help: replace the `Into` implementation with `From<PdError>`
|
59 ~ impl<T, BE> From<PdError> for Result<T, Error<BE>> {
60 ~ fn from(val: PdError) -> Self {
61 ~ Err(Error::Pd(val))
|
Raw Output:
src/lib.rs:59:1:e:error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/lib.rs:59:1
|
59 | impl<T, BE> Into<Result<T, Error<BE>>> for PdError {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-F clippy::from-over-into` implied by `-F clippy::style`
help: replace the `Into` implementation with `From<PdError>`
|
59 ~ impl<T, BE> From<PdError> for Result<T, Error<BE>> {
60 ~ fn from(val: PdError) -> Self {
61 ~ Err(Error::Pd(val))
|
__END__
|
cargo clippy:
src/lib.rs#L65
[clippy] reported by reviewdog 🐶
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/lib.rs:65:1
|
65 | impl<BE> Into<Error<BE>> for PdError {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
help: replace the `Into` implementation with `From<PdError>`
|
65 ~ impl<BE> From<PdError> for Error<BE> {
66 ~ fn from(val: PdError) -> Self {
67 ~ Error::Pd(val)
|
Raw Output:
src/lib.rs:65:1:e:error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/lib.rs:65:1
|
65 | impl<BE> Into<Error<BE>> for PdError {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
help: replace the `Into` implementation with `From<PdError>`
|
65 ~ impl<BE> From<PdError> for Error<BE> {
66 ~ fn from(val: PdError) -> Self {
67 ~ Error::Pd(val)
|
__END__
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Loading