Dynamic data support for plotting, recording, and replaying/publishing #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta::getMemberTypeKindById and CommonData::getNestedMemberAndIdByName to make it simpler in readValue (and for future use of replayer)
…sting problems: 1. DynamicData::set_*_value is returning RETCODE::UNSUPPORTED when trying to populate the cloned dynamicData sample, despite the get_int16_value and other get_*_value functions returning the correct values (ie correct memberId and datatypes). 2. Trying to write the dynamic sample (even without trying to edit the sample values) to the dynamic data writer is giving a serialization error: (42232|15776) WARNING: DynamicSample::serialized_size: DynamicDataBase::serialized_size failed! (42232|15776) ERROR: DataWriterImpl::serialize_sample: failed to serialize sample data
|
The |
|
Yeah I can't change what version of DDS we're using, but that change shouldn't affect the changes I made (I didn't comment those things out in the version I pushed), I just mentioned it in case it becomes relevant |
|
PR #43 was just merged which resulted in a conflict here, please merge from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the replayer/publisher for dynamic data still doesn't work, here are the issues I'm stuck on:
DynamicData::set_*_valueis returning RETCODE::UNSUPPORTED when trying to populate the cloned (and also original to check if just clone was failing) dynamicData sample, despite the get_*_value functions returning the correct values (ie correct memberId and datatypes).In case it's relevant, I'm using OpenDDS 3.28.1 (and have to locally comment out
#include <dds/DCPS/EncapsulationHeader.h>in topic_replayer.cpp, and I have to changeDynamicMetaStruct::getValue(___ , OpenDDS::DCPS::TypeSupportImpl*)toDynamicMetaStruct::getValue(___ , const OpenDDS::DCPS::TypeSupportImpl*)on my computer to run everything as a result), and I'm on Windows only.Disclaimer: I'm not a dev, hopefully this isn't attrocious.