335 create lockfile #357
Open
335 create lockfile #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songmeo
force-pushed
the
335-create-lockfile
branch
2 times, most recently
from
16a5e15 to
0a58cc9
Compare
songmeo
force-pushed
the
335-create-lockfile
branch
from
0a58cc9 to
adacb45
Compare
songmeo
force-pushed
the
335-create-lockfile
branch
from
3330ca3 to
3fcb454
Compare
pavel-kirienko
requested changes
Jun 16, 2025
songmeo
force-pushed
the
335-create-lockfile
branch
from
2260924 to
f331a60
Compare
pavel-kirienko
approved these changes
Jun 17, 2025
pycyphal/dsdl/_compiler.py
Outdated
| output_directory=output_directory, | ||
| ) as lockfile: | ||
| if lockfile: | ||
| # Generate code |
There was a problem hiding this comment.
Suggested change
| # Generate code |
pycyphal/dsdl/_lockfile.py
Outdated
Comment on lines
32
to
34
| if self._lockfile is not None: | ||
| return self.remove() | ||
| return None |
There was a problem hiding this comment.
Suggested change
| if self._lockfile is not None: | |
| return self.remove() | |
| return None | |
| if self._lockfile is not None: | |
| self.remove() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #335