Skip to content

Commit

Permalink
engines in package.json (#508)
Browse files Browse the repository at this point in the history
* engines in package.json

* drop 18.x

* update cypress pipeline for node 20

* node 20 for cypress

---------

Co-authored-by: Andi Braimllari <>
  • Loading branch information
AndiBraimllari authored Aug 28, 2024
1 parent 55eb367 commit d5ce13b
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 4 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 20

# Install NPM dependencies, cache them correctly
# and run all Cypress tests
- name: Cypress run
uses: cypress-io/github-action@v5
uses: cypress-io/github-action@v6
with:
build: npm run build
start: npm run start:mock-with-server
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
4 changes: 4 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"name": "quill",
"version": "0.0.0",
"scripts": {
"engines": {
"node": "^20",
"npm": "^10"
},
"scripts": {
"ng": "ng",
"install:mock-server": "cd mock-server; npm install",
"start": "ng serve",
Expand Down Expand Up @@ -52,4 +56,4 @@
"prettier": "^3.2.5",
"typescript": "~5.4.5"
}
}
}

0 comments on commit d5ce13b

Please sign in to comment.