Symfony upgrade 5 4 #1813
Draft
Symfony upgrade 5 4 #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Session should not be injected as a service anymore. Rather, the request stack should be used to get the session from the current http request. In addition some unused session services have been removed from DI
Todo: [] - Use the symfony driver (browserkit) as default driver to run the tests on. Now we seem to use Selenium2 with Chrome by default. And that causes some of the tests to fail. Wayf tetss for example are unable to click certain links because they are not on the page? [] - Sessions are not stable yet. The authentication state is lost regularly. Seems to relate to the loop guard section that is commented out in: src/OpenConext/EngineBlockBundle/EventListener/AuthenticationStateInitializer.php [] - I started running the different features, and fixed some issues here and there. But I suggest to use the failing tests to find/fix the remaining issues present in the EB upgrade
- Install a new Pimple version to keep DiContainer in the air - Enabled Symfony flex to ensure we only install SF 5.4 packages - APCU was disabled as the cache adapter for doctrine - app.php was butchered, needs further optimization and fixing - SamlValueObject was upgraded to a version supporting PHP8 (dev)
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.