Add explicit IdP signing key feedback #1791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/add-expicit-signing-key-check
branch
2 times, most recently
from
cefd336 to
d6f3eac
Compare
thijskh
reviewed
Jan 28, 2025
pablothedude
force-pushed
the
feature/add-expicit-signing-key-check
branch
from
718c5e1 to
aba490c
Compare
|
I've added a check to prevent more than one certificate because that doesn't seem to occur. |
johanib
reviewed
Feb 10, 2025
theme/base/templates/modules/Authentication/View/Feedback/unknown-signing-key.html.twig
Show resolved
Hide resolved
theme/openconext/templates/modules/Authentication/View/Feedback/unknown-signing-key.html.twig
Show resolved
Hide resolved
baszoetekouw
requested changes
Feb 10, 2025
I will add a unit test. |
pablothedude
force-pushed
the
feature/add-expicit-signing-key-check
branch
2 times, most recently
from
ae4f60c to
e63680a
Compare
An explicit IdP signing key check is added for easier debugging. The ease of debugging should outweigh the drawbacks of moving the responsibility of the SAML2 library also to EB and the performance penalties for doing this twice. #1328
pablothedude
force-pushed
the
feature/add-expicit-signing-key-check
branch
from
e63680a to
86a9e87
Compare
johanib
approved these changes
Feb 12, 2025
|
Apart from the missing test, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explicit IdP signing key check is added for easier debugging.
The ease of debugging should outweigh the drawbacks of moving the responsibility of the SAML2 library also to EB and the performance penalties for doing this twice.
#1328