Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Game Sales Analysis #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Video Game Sales Analysis #25

wants to merge 2 commits into from

Conversation

ZestyZeeshan
Copy link

@ZestyZeeshan ZestyZeeshan commented Oct 3, 2023 •
edited by AKACHI-4
Loading

please accept my pull request

refer #7

@AKACHI-4 AKACHI-4 changed the title Created using Colaboratory Video Game Sales Analysis Oct 3, 2023
@AKACHI-4 AKACHI-4 added the hacktoberfest This label is for all the issues which comes under hacktoberfest. label Oct 3, 2023
@AKACHI-4
Copy link
Collaborator

AKACHI-4 commented Oct 3, 2023

Hey @ZestyZeeshan,

After reviewing your PR, there are some changes you need to make..

The dataset you have used already has a visualization notebook available. Kindly select a different one and provide a link to that dataset in your notebook.ipnyb. I would recommend adding your code to the existing notebook. You can start by mentioning your dataset towards the end.

I hope you understand.

Best regards,

@ZestyZeeshan
Copy link
Author

hi,
there is some problem , now i had used different dataset and its run error free on jupyter notebook but i try to run the same in google colab its dont show any error but visualisation are not showing .

@AdarshRawat1 AdarshRawat1 added the enhancement New feature or request label Oct 15, 2023
@AKACHI-4
Copy link
Collaborator

@ZestyZeeshan feel free to discuss error I can try to troubleshoot for u ... nd u also can commit jupyter notebook.

@ZestyZeeshan
Copy link
Author

kindly merge my pr,which is in jupyter notebook

@AKACHI-4
Copy link
Collaborator

Hey @ZestyZeeshan You only have to commit 1 file and name is notebook.ipnyb

kindly do this changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest This label is for all the issues which comes under hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZestyZeeshan @AKACHI-4 @AdarshRawat1