Fix remove_flyback algorithm #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2024 16:46
…ames per probe position
|
This looks like it is working. Can we issue a release candidate with this and the other pull requests? I want to test it a little more thoroughly. |
|
@ercius Sorry for the delayed response. As part of the CI for a PR a wheel is built ( just download the the artifacts ) you can use that for testing. The CI is currently failing because you are removing |
added 2 commits
September 16, 2024 10:58
…ar line later. Its best to keep things consistent.
|
@cjh1 Thanks for finding my error. I've added in scan_positions and will grab the artifact to more fully test this new algorithm. |
|
@cjh1 I think this is good to merge. Can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current algorithm for removing the flyback doe snot properly account for multiple frames per probe position.
This new algorithm is designed to account for that problem.
Its not ready yet. I need to build new stempy version to test it.