Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] manage dissemination list and send PDFs (#5551) #9682

Merged
merged 81 commits into from
Jan 30, 2025

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX commented Jan 22, 2025

Proposed changes

  • Creation, update and deletion of dissemination lists.
  • Use of dissemination lists to send emails.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Try with :

  • PDF files (display disseminate button) / other files
  • EE activated / not activated (display EE chip and disable disseminate button)
  • User with capability KNOWLEDGE_KNDISSEMINATION / or not (allow to disseminate files)
  • User with capability SETTINGS_SETDISSEMINATION / or not (allow to manage lists)

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 37.09677% with 117 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (219118b) to head (acef7bc).
Report is 16 commits behind head on release/6.5.0.

Files with missing lines Patch % Lines
...ules/disseminationList/disseminationList-domain.ts 36.92% 82 Missing ⚠️
...latform/opencti-graphql/src/manager/taskManager.js 20.00% 16 Missing ⚠️
...pencti-graphql/src/domain/backgroundTask-common.js 8.33% 11 Missing ⚠️
...es/disseminationList/disseminationList-resolver.ts 50.00% 6 Missing ⚠️
...rm/opencti-graphql/src/manager/activityListener.ts 50.00% 1 Missing ⚠️
...s/disseminationList/disseminationList-converter.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9682      +/-   ##
=================================================
+ Coverage          64.29%   64.65%   +0.35%     
=================================================
  Files                653      655       +2     
  Lines              62473    63370     +897     
  Branches            6918     7791     +873     
=================================================
+ Hits               40169    40972     +803     
- Misses             22304    22398      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the title Issue/5551 chunk2 Issue/5551 chunk2 (Dissemination Lists) Jan 27, 2025
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the title Issue/5551 chunk2 (Dissemination Lists) [backend/frontend] Issue/5551 chunk2 (Dissemination Lists) Jan 27, 2025
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review January 28, 2025 09:53
@Gwendoline-FAVRE-FELIX

This comment was marked as resolved.

@Archidoit

This comment was marked as resolved.

@Archidoit

This comment was marked as resolved.

@Archidoit

This comment was marked as resolved.

@labo-flg labo-flg changed the title [backend/frontend] Issue/5551 chunk2 (Dissemination Lists) [backend/frontend] manage dissemination list and send PDFs (#5551) Jan 28, 2025
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 827225f into release/6.5.0 Jan 30, 2025
3 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/5551-chunk2 branch January 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mailing lists in the platform for the default mailer
7 participants