Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] When adding a relationship to a container assigned to someone, notification shows unknown (#8684) #9014

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ValentinBouzinFiligran
Copy link
Member

Proposed changes

  • relationships condition added on generateUpdateMessage

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (0dc1991) to head (5f7f77f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9014      +/-   ##
==========================================
- Coverage   66.28%   66.25%   -0.04%     
==========================================
  Files         597      597              
  Lines       61098    61163      +65     
  Branches     6288     6291       +3     
==========================================
+ Hits        40501    40521      +20     
- Misses      20597    20642      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

The relationship representative is not always correct.
Exemple, if I create this relationship :
image

I get in the history :
image

--> The representative of Observed Data is not correct

@Archidoit
Copy link
Member

If the representative is too long, it is not fully displayed in the tooltip :
image

@Archidoit
Copy link
Member

If the representative is too long, it is not fully displayed in the tooltip : image

--> issue created for this #9021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants