Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] add ability to enrich in draft context (#6577) #8858

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Oct 31, 2024

Proposed changes

  • add enrichment in draft context: both manual and auto enrichment
  • add draft entity_id context to know where the draft was created from

Related PR : OpenCTI-Platform/client-python#783

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec marked this pull request as draft October 31, 2024 16:55
@JeremyCloarec JeremyCloarec changed the base branch from master to release/6.4.0 October 31, 2024 16:55
@JeremyCloarec JeremyCloarec added filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository labels Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.36%. Comparing base (0a608c0) to head (5af11c2).
Report is 2 commits behind head on release/6.4.0.

Files with missing lines Patch % Lines
...tform/opencti-graphql/src/domain/stixCoreObject.js 0.00% 6 Missing ⚠️
...tform/opencti-graphql/src/database/file-storage.js 50.00% 2 Missing ⚠️
...-platform/opencti-graphql/src/domain/enrichment.js 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #8858      +/-   ##
=================================================
- Coverage          64.37%   64.36%   -0.01%     
=================================================
  Files                609      609              
  Lines              58286    58297      +11     
  Branches            6433     6441       +8     
=================================================
+ Hits               37520    37523       +3     
- Misses             20766    20774       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec removed the multi-repository For contribution that requires PR in several repository label Nov 7, 2024
@JeremyCloarec JeremyCloarec merged commit c437aed into release/6.4.0 Nov 7, 2024
5 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/6577chunk5 branch November 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants