Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Add quick actions on Assignee/Participant (#4333) #8513

Merged
merged 23 commits into from
Oct 14, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Sep 26, 2024

Proposed changes

  • Design update of Assignee/Participant chip
  • Add quick button on Assignee/Participant to open a drawer to easily add a user
  • Display first the current user in the dropdown list
  • Display a - when you don't have labels
  • Uniformized spacing on Assignee/Participant/Labels with other components

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

image

@frapuks frapuks changed the base branch from master to release/6.4.0 September 26, 2024 12:36
@frapuks frapuks marked this pull request as ready for review September 30, 2024 14:24
@frapuks frapuks self-assigned this Sep 30, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Sep 30, 2024
@Archidoit
Copy link
Member

Missing a 'S' in 'Add new Participant' (to be consistant with 'Add new labels' and 'Add new attributes' :

image

image

(maybe also the Upper case to be consistant with 'Add new labels') :
image

Same for Assignee(s) / Participant(s) in the text field --> Assignees / Participants (to be consistant with 'Labels')

@Archidoit
Copy link
Member

Behavior tested, working well

@frapuks frapuks changed the title Add quick actions on Assignee/Participant [frontend/backend] Add quick actions on Assignee/Participant (#4333) Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/6.4.0@f192686). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/6.4.0    #8513   +/-   ##
================================================
  Coverage                 ?   66.09%           
================================================
  Files                    ?      606           
  Lines                    ?    60900           
  Branches                 ?     6240           
================================================
  Hits                     ?    40250           
  Misses                   ?    20650           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👌

@frapuks frapuks merged commit bc91e49 into release/6.4.0 Oct 14, 2024
5 checks passed
@frapuks frapuks deleted the issue/4333 branch October 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants