Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Change the "representation" key used in an investigation for an observable of type "File" (#7634) #8504

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX commented Sep 25, 2024

Proposed changes

  • Change the "representation" key used in an investigation and knowledge for an observable of type "File".
  • In the graph, make it possible to search an observable "File" by hash.
  • Add more detail about the observable in the "Investigation Entity detail" card (hashes and names).
  • On tooltip, add additional information about the observable (hashes and names).

Related issues

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (0fa9e2d) to head (b56652c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8504      +/-   ##
==========================================
+ Coverage   66.21%   66.23%   +0.01%     
==========================================
  Files         597      597              
  Lines       60433    60433              
  Branches     6201     6204       +3     
==========================================
+ Hits        40017    40025       +8     
+ Misses      20416    20408       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the base branch from master to release/6.4.0 September 25, 2024 14:56
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review September 30, 2024 12:49
@SouadHadjiat

This comment was marked as resolved.

@labo-flg
Copy link
Member

labo-flg commented Oct 3, 2024

@Gwendoline-FAVRE-FELIX I've pushed with this commit missing translation for "Additional names".

Also, the tooltip was not translated at all.

Otherwise, all good to me !

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 61130e5 into master Oct 3, 2024
6 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/7634 branch October 3, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
3 participants