Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] ignore objectOrganization in reindexing (#8495) #8496

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Sep 25, 2024

Proposed changes

  • remove objectOrganization when reindexing to prevent issue when deleting

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (d507f71) to head (e681848).
Report is 81 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8496   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files         597      597           
  Lines       60422    60423    +1     
  Branches     6204     6207    +3     
=======================================
+ Hits        40008    40011    +3     
+ Misses      20414    20412    -2     
Flag Coverage Δ
66.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Oct 11, 2024
@SamuelHassine SamuelHassine merged commit 39fd0ee into master Oct 14, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/8495 branch October 14, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants