Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] In knowledge graph, do not re-apply forces when adding a new entity (#7298) #8454

Closed
wants to merge 10 commits into from

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

Proposed changes

  • When you place entities manually and then add a new entity. If the forces are deactivated, make sure that the entities stay in the place they were given.

Related issues

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.14%. Comparing base (a277b00) to head (a5b583b).
Report is 14 commits behind head on release/6.4.0.

Files with missing lines Patch % Lines
...atform/opencti-graphql/src/modules/ai/ai-domain.ts 0.00% 4 Missing ⚠️
...ti-platform/opencti-graphql/src/database/ai-llm.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #8454      +/-   ##
=================================================
- Coverage          66.14%   66.14%   -0.01%     
=================================================
  Files                597      597              
  Lines              60500    60508       +8     
  Branches            6200     6202       +2     
=================================================
+ Hits               40020    40025       +5     
- Misses             20480    20483       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review September 24, 2024 09:16
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as draft September 24, 2024 09:20
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review September 24, 2024 13:07
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the base branch from master to release/6.4.0 September 25, 2024 14:54
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as draft September 26, 2024 09:17
@Archidoit

This comment was marked as resolved.

@Archidoit

This comment was marked as resolved.

@Archidoit
Copy link
Member

Behavior ok for reports 👍
Need to check the question of nodes position storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
6 participants