-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Improve redis sessions list perf (#7943) #8119
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8119 +/- ##
==========================================
- Coverage 66.30% 66.28% -0.02%
==========================================
Files 597 597
Lines 61033 61092 +59
Branches 6275 6282 +7
==========================================
+ Hits 40468 40497 +29
- Misses 20565 20595 +30 ☔ View full report in Codecov by Sentry. |
feb005e
to
812b0de
Compare
}; | ||
export const getSession = async (key: string) => { | ||
export const getSession = async (baseKeyId: string) => { | ||
const key = `{${PLATFORM_KEY_SESSIONS}}:${baseKeyId}`; // Key of a list must be attached to the same redis slot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, does it mean the session key has now PLATFORM_KEY_SESSIONS as a prefix ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is wrong with this {${PLATFORM_KEY_SESSIONS}}:${baseKeyId}
, when I debug this method, I find myself with a duplicate {${PLATFORM_KEY_SESSIONS}}: prefix, I'm not sure we should add it here, since the key is already named in redis with this prefix
476147f
to
2fcd37b
Compare
opencti-platform/opencti-front/src/private/components/settings/SessionsList.jsx
Outdated
Show resolved
Hide resolved
df19b3f
to
ef259a7
Compare
ef259a7
to
579ac1e
Compare
579ac1e
to
a43dce1
Compare
f8359b7
to
558e6c1
Compare
4b636fd
to
0edae7c
Compare
0edae7c
to
d0e063c
Compare
d0e063c
to
2bb705b
Compare
- Prevent any event loop blocking - Adapt frontend display to show impersonate option - Limit the number of sessions displayed - Remove feature flag for telemetry - Add new API for global sessions cleanup - Remove delUserContext to only let the key die from ttl
2bb705b
to
dfe2763
Compare
Proposed changes
Related issues
Checklist