Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] check user access before merging and add new capa to bypass (#7043) #7761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JeremyCloarec
Copy link
Contributor

Proposed changes

  • check user access to all merge dependencies before merging
  • add new BYPASSMERGE capa to bypass this check

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.21%. Comparing base (1aa3e4b) to head (a9e9a98).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...latform/opencti-graphql/src/database/middleware.js 81.81% 4 Missing ⚠️
...pencti-graphql/src/database/data-initialization.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7761      +/-   ##
==========================================
- Coverage   66.21%   66.21%   -0.01%     
==========================================
  Files         597      597              
  Lines       60422    60436      +14     
  Branches     6207     6206       -1     
==========================================
+ Hits        40011    40017       +6     
- Misses      20411    20419       +8     
Flag Coverage Δ
66.21% <79.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Aug 9, 2024
@JeremyCloarec JeremyCloarec force-pushed the issue/7043 branch 2 times, most recently from e6a2891 to 624a103 Compare September 16, 2024 08:36
@JeremyCloarec JeremyCloarec marked this pull request as ready for review September 16, 2024 08:36
@labo-flg
Copy link
Member

What's the status on this PR @JeremyCloarec ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants