Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Create Relationship" Button to Objects #7034

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Added a "Create Relationship" button to most entity pages (not containers)
  • Replaced speed dial in relationship creation drawers
  • Added resolver to get valid targets for nested ref relationships
  • Nested object drawer only shows valid targets now

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.22%. Comparing base (d507f71) to head (cb69f25).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7034      +/-   ##
==========================================
+ Coverage   66.21%   66.22%   +0.01%     
==========================================
  Files         597      597              
  Lines       60422    60442      +20     
  Branches     6204     6210       +6     
==========================================
+ Hits        40008    40030      +22     
+ Misses      20414    20412       -2     
Flag Coverage Δ
66.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the community use to identify PR from community label May 21, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from d30baf0 to f863b8b Compare May 21, 2024 12:30
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from f863b8b to 714a0db Compare June 6, 2024 15:36
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 3 times, most recently from ab87c9e to 2827bcb Compare June 17, 2024 18:16
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from a8e30c3 to 3a5fb83 Compare August 6, 2024 14:42
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from b1c0107 to 8d1464c Compare August 13, 2024 11:20
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from 93f3707 to f9bf6d5 Compare August 21, 2024 19:03
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 2 times, most recently from 9cda64d to 7440b45 Compare September 10, 2024 12:40
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from 7315427 to d55f929 Compare September 17, 2024 12:50
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from 1d9c3c4 to 66073bf Compare September 24, 2024 12:19
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from 66073bf to cb69f25 Compare September 24, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants