Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix call to stixCoreRelationshipsDistribution #6580

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Apr 4, 2024

If a country has a marking unavailable for a user, the dashboard query stixCoreRelationshipsDistribution crashes because said country is Restricted.

This is due to PR #6323.

Now the relationshipDistributions data are checked and returned with "Restricted" representative if the user cannot access one this side of the relationship. Before they were filtered out, leading to inconsistencies (see #6319).

The bug happens because we do a ...on Country { name } and name is non-nullable, but will be null because it's restricted.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.78%. Comparing base (b2aa068) to head (a35976a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6580   +/-   ##
=======================================
  Coverage   67.78%   67.78%           
=======================================
  Files         532      532           
  Lines       65102    65102           
  Branches     5470     5471    +1     
=======================================
  Hits        44129    44129           
  Misses      20973    20973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit f127f77 into master Apr 5, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6319-fix-countries branch April 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants