Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix bulk search not returning HashedObservable (#6522) #6548

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Apr 3, 2024

Proposed changes

  • add HashedObservable in searchStixCoreObjectsLinesSearchQuery

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact self-assigned this Apr 3, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review April 3, 2024 07:31
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Apr 3, 2024
@SamuelHassine SamuelHassine merged commit 512a674 into master Apr 3, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/6522 branch April 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants