[frontend] Feedback addressed

OpenCTI-Platform · Sep 24, 2024 · 3282c9f · 3282c9f
1 parent 35a2b3d
commit 3282c9f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/opencti-platform/opencti-front/src/components/FilterIconButton.tsx b/opencti-platform/opencti-front/src/components/FilterIconButton.tsx
@@ -21,7 +21,6 @@ export interface FilterIconButtonProps {
   redirection?: boolean;
   helpers?: handleFilterHelpers;
   availableRelationFilterTypes?: Record<string, string[]>;
-  required?: boolean;
   entityTypes?: string[];
   filtersRestrictions?: FiltersRestrictions;
   searchContext?: FilterSearchContext;

diff --git a/...i-front/src/private/components/analyses/external_references/ExternalReferenceCreation.tsx b/...i-front/src/private/components/analyses/external_references/ExternalReferenceCreation.tsx
@@ -227,8 +227,8 @@ const ExternalReferenceCreation: FunctionComponent<ExternalReferenceCreationProp
               file: '',
             }}
             validationSchema={externalReferenceValidation(t_i18n)}
-            validateOnChange={false} // Validation will occur on submission, required fields all have *'s
-            validateOnBlur={false} // Validation will occur on submission, required fields all have *'s
+            validateOnChange={true}
+            validateOnBlur={true}
             onSubmit={onSubmit}
             onReset={() => {
               onResetClassic();
@@ -329,8 +329,8 @@ const ExternalReferenceCreation: FunctionComponent<ExternalReferenceCreationProp
               file: '',
             }}
             validationSchema={externalReferenceValidation(t_i18n)}
-            validateOnChange={false} // Validation will occur on submission, required fields all have *'s
-            validateOnBlur={false} // Validation will occur on submission, required fields all have *'s
+            validateOnChange={true}
+            validateOnBlur={true}
             onReset={onResetContextual}
           >
             {({ submitForm, handleReset, isSubmitting, setFieldValue }) => (

diff --git a/...latform/opencti-front/src/private/components/analyses/opinions/OpinionEditionOverview.jsx b/...latform/opencti-front/src/private/components/analyses/opinions/OpinionEditionOverview.jsx
@@ -119,6 +119,7 @@ const OpinionEditionOverviewComponent = (props) => {
     x_opencti_workflow_id: convertStatus(t_i18n, opinion),
     confidence: opinion.confidence,
     explanation: opinion.explanation,
+    opinion: opinion.opinion,
   };
 
   return (