Skip to content

add tutorial for momentum correction of already binned datasets #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

add tutorial for momentum correction of already binned datasets #570

merged 3 commits into from
Apr 14, 2025

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Apr 4, 2025

As recently requested by Moritz Hoesch

@coveralls
Copy link
Collaborator

coveralls commented Apr 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14442883047

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.063%
Totals Coverage Status
Change from base Build 14432894692: 0.0%
Covered Lines: 8166
Relevant Lines: 8870
💛 - Coveralls

kutnyakhov
kutnyakhov reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@kutnyakhov kutnyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few minor corrections inside of tutorial and small visualisation comparison.
In general looks good and can be merged.

@rettigl
Copy link
Member Author

rettigl commented Apr 14, 2025

I've made a few minor corrections inside of tutorial and small visualisation comparison. In general looks good and can be merged.
@kutnyakhov Thanks for your suggestions, could you approve then?

kutnyakhov
kutnyakhov approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@kutnyakhov kutnyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go

@kutnyakhov kutnyakhov merged commit 53a1147 into main Apr 14, 2025
5 checks passed
@kutnyakhov kutnyakhov deleted the tutorial_for_binned_data branch April 14, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kutnyakhov kutnyakhov kutnyakhov approved these changes

@zain-sohail zain-sohail Awaiting requested review from zain-sohail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @kutnyakhov